HomePhabricator

[DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

Description

[DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

Summary:
Instead of using the offset of the contained compile unit, we use it's
ID. The goal of this change is two-fold:

  • free up space in the user_id_t representation to enable storing the debug-info-carrying section (debug_types/debug_info) without decreasing the amount of debug info we can address (as would be the case with D61503).
  • be a step towards supporting DWO files containing more than one unit (important for debug_types+dwo, but can also happen with regular dwo+lto). For this part to fully work we'd still need to add a way to lookup the SymbolFileDWO without going through GetCompileUnitAtIndex, but making sure things don't accidentally work because the SymbolFile ID is the same as compile unit offset is a step towards that.

Reviewers: JDevlieghere, clayborg, aprantl

Subscribers: mehdi_amini, dexonsmith, tberghammer, jankratochvil, lldb-commits

Differential Revision: https://reviews.llvm.org/D61783

Details

Committed
labathMay 13 2019, 1:58 AM
Differential Revision
D61783: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs
Parents
rL360564: @skipIfLinux flaky lldb-mi tests
Branches
Unknown
Tags
Unknown