HomePhabricator

Revert r359325 "[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to…

Description

Revert r359325 "[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void"

Changing INTERCEPT_FUNCTION to return void is not functionally correct.
IMO the best way to communicate failure or success of interception is
with a return value, not some external address comparison.

This change was also creating link errors for _except_handler4_common,
which is exported from ucrtbase.dll in 32-bit Windows.

Also revert dependent changes r359362 and r359466.

Details

Committed
rnkApr 30 2019, 1:59 PM
Parents
rL359610: [libFuzzer] Replace -seed_corpus to better support fork mode on Win
Branches
Unknown
Tags
Unknown