HomePhabricator

Let llvm-cvtres (and lld-link) report duplicate resources

Description

Let llvm-cvtres (and lld-link) report duplicate resources

If two .res files contain the same resource, cvtres.exe (and hence
link.exe) reject the input with this message:

CVTRES : fatal error CVT1100: duplicate resource.  type:STRING, name:101, language:0x0409
LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt

llvm-cvtres (and lld-link) used to silently pick one of the duplicate
resources instead. This patch makes them report an error as well.
We slightly improve on cvtres by printing the name of two .res files
containing duplicate entries as well.

Differential Revision: https://reviews.llvm.org/D61049

Details

Committed
nicoApr 24 2019, 4:42 AM
Differential Revision
D61049: Let llvm-cvtres (and lld-link) report duplicate resources
Parents
rL359082: [X86][SSE] Add masked bit test cases for PR26697
Branches
Unknown
Tags
Unknown

Event Timeline

saghir added a subscriber: saghir.Apr 26 2019, 12:44 PM

Hi, your patch seems to be causing buildbot failures for the following buildbots:
https://lab.llvm.org:8011/builders/clang-ppc64be-linux
https://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
https://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt

Specifically, this tools/llvm-cvtres/duplicate.test is causing LIT failures on BE-linux. The error can be seen at:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26780/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aduplicate.test

Can you please pull this patch out and re-commit after you are able to resolve the failure. Thanks!