HomePhabricator

Discard debuginfo for object files empty after GC

Description

Discard debuginfo for object files empty after GC

Patch by Robert O'Callahan.

Rust projects tend to link in all object files from all dependent
libraries and rely on --gc-sections to strip unused code and data.
Unfortunately --gc-sections doesn't currently strip any debuginfo
associated with GC'ed sections, so lld links in the full debuginfo from
all dependencies even if almost all that code has been discarded. See
https://github.com/rust-lang/rust/issues/56068 for some details.

Properly stripping debuginfo for discarded sections would be difficult,
but a simple approach that helps significantly is to mark debuginfo
sections as live only if their associated object file has at least one
live code/data section. This patch does that. In a (contrived but not
totally artificial) Rust testcase linked above, it reduces the final
binary size from 46MB to 5.1MB.

Differential Revision: https://reviews.llvm.org/D54747

Details

Committed
ruiuApr 10 2019, 3:37 AM
Differential Revision
D54747: Discard debuginfo for object files empty after GC
Parents
rL358068: [AsmPrinter] Delete unused RangeSpanList::addRange
Branches
Unknown
Tags
Unknown