HomePhabricator

[DAGCombine] Improve Lifetime node chains.

Description

[DAGCombine] Improve Lifetime node chains.

Improve both start and end lifetime nodes chain dependencies.

Reviewers: courbet

Reviewed By: courbet

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D59795

Details

Committed
niravdMar 29 2019, 7:09 AM
Reviewer
courbet
Differential Revision
D59795: [DAGCombine] Improve Lifetime node chains.
Parents
rL357255: clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)
Branches
Unknown
Tags
Unknown

Event Timeline

@niravd I'm not certain but I think this is causing the EXPENSIVE_CHECKS failures: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/16678

dlj added a subscriber: dlj.Apr 3 2019, 3:47 PM

@niravd I'm not certain but I think this is causing the EXPENSIVE_CHECKS failures: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/16678

I'm also seeing (apparently) infinite loops when building a fairly straightforward input.

@niravd are these failing tests (from the expensive checks run) sufficient?
Failing Tests (3):

LLVM :: CodeGen/X86/StackColoring.ll
LLVM :: CodeGen/X86/unwindraise.ll
LLVM :: DebugInfo/COFF/lexicalblock.ll

I'll go ahead and revert this change, since presumably the test cases are sufficient... but if not, let me know. I might be able to reduce a different example.