HomePhabricator

Fix two more issues with r356652

Description

Fix two more issues with r356652

The first problem was a use-after-free in the tests (detected by asan
bots). The temporary array created for the "create" call is guaranteed
to live only until the end of the statement. The fix there is to store
the test data in a local variable to ensure it has the right lifetime

The second issue is broken BUILD_SHARED_LIBS build, which I fix by
adding the appropriate BinaryFormat dependency to the Object unit tests.

Details

Committed
labathMar 21 2019, 3:21 AM
Parents
rL356654: [RISCV][NFC] Remove old CHECK lines from linker-relaxation.s test
Branches
Unknown
Tags
Unknown