HomePhabricator

[PGO] Context sensitive PGO (part 3)
AuditedrL355330

Description

[PGO] Context sensitive PGO (part 3)

Part 3 of CSPGO changes (mostly related to PassMananger).

Differential Revision: https://reviews.llvm.org/D54175

Details

Auditors
hctim
Committed
xurMar 4 2019, 12:21 PM
Differential Revision
D54175: [PGO] context sensitive PGO
Parents
rL355329: Fix Windows build after UserIDResolver patch.
Branches
Unknown
Tags
Unknown

Event Timeline

hctim raised a concern with this commit.Mar 4 2019, 1:51 PM
hctim added a subscriber: hctim.

Hi, looks like this change has broken one of the sanitizer buildbots (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/20104). The fix is likely a simple /s/InstrUse/CSInstrUse in llvm/trunk/tools/opt/opt.cpp:419.

Thanks.

This commit now has outstanding concerns.Mar 4 2019, 1:51 PM
hctim accepted this commit.Mar 4 2019, 2:36 PM

Fixed in r355338. :)

All concerns with this commit have now been addressed.Mar 4 2019, 2:36 PM