HomePhabricator

[RegAllocGreedy] Take last chance recoloring into account in evicting.

Description

[RegAllocGreedy] Take last chance recoloring into account in evicting.

Last chance recoloring inserts into FixedRegisters those virtual
registers it is attempting to assign a physical register to.

We must consider these when we consider candidates for eviction so that
we do not end up evicting something while we are attempting to recolor
to assign it.

This is hitting in an out-of-tree target and no longer reproduces on
trunk. That does not appear to be a result of it having been fixed, but
rather, it appears that optimization changes and/or other changes to
register allocation mask the problem.

I haven't found a way to come up with a reasonable test case for this
(i.e. one that I can actually commit to open source, is reasonable
in size, and actually reproduces the issue).

rdar://problem/45708741

Details

Committed
rudkxFeb 13 2019, 2:56 PM
Differential Revision
D58200: [RegAllocGreedy] Take last chance recoloring into account in evicting.
Parents
rL353987: [AVR] Fix a typo - 's/analisys/analysis'
Branches
Unknown
Tags
Unknown