HomePhabricator

Bump minimum toolchain version

Description

Bump minimum toolchain version

Summary:
The RFC on moving past C++11 got good traction:

http://lists.llvm.org/pipermail/llvm-dev/2019-January/129452.html

This patch therefore bumps the toolchain versions according to our policy:

llvm.org/docs/DeveloperPolicy.html#toolchain

Subscribers: mgorny, jkorous, dexonsmith, llvm-commits, mehdi_amini, jyknight, rsmith, chandlerc, smeenai, hans, reames, lattner, lhames, erichkeane

Differential Revision: https://reviews.llvm.org/D57264

Details

Committed
jfbFeb 6 2019, 9:20 PM
Differential Revision
D57264: Bump minimum toolchain version
Parents
rL353373: Move the SMT API to LLVM
Branches
Unknown
Tags
Unknown

Event Timeline

This looks to have broken optimized tablegen builds with VS2015 even when the new switch is enabled. I'm guessing that option isn't passed into the cmake run for generating the optimized tablegen?

jfb added a comment.Feb 7 2019, 10:23 AM

This looks to have broken optimized tablegen builds with VS2015 even when the new switch is enabled. I'm guessing that option isn't passed into the cmake run for generating the optimized tablegen?

Can you clarify what exactly is broken? Is there a bot with logs?
The new minimum VS version is 2017, so indeed something looks wrong.

This looks to have broken optimized tablegen builds with VS2015 even when the new switch is enabled. I'm guessing that option isn't passed into the cmake run for generating the optimized tablegen?

Can you clarify what exactly is broken? Is there a bot with logs?
The new minimum VS version is 2017, so indeed something looks wrong.

I discovered this when trying to build LLVM locally today. I still use VS2015, which should work if the cmake variable for allowing building with an old toolchain is set. I set it, but discovered that the cmake step generating optimized tablegen still fails with the soft error.

jfb added a comment.Feb 7 2019, 10:54 AM

This looks to have broken optimized tablegen builds with VS2015 even when the new switch is enabled. I'm guessing that option isn't passed into the cmake run for generating the optimized tablegen?

Can you clarify what exactly is broken? Is there a bot with logs?
The new minimum VS version is 2017, so indeed something looks wrong.

I discovered this when trying to build LLVM locally today. I still use VS2015, which should work if the cmake variable for allowing building with an old toolchain is set. I set it, but discovered that the cmake step generating optimized tablegen still fails with the soft error.

I don't have a Windows machine handy. Could you look into how the tablegen configuration stuff is piped through? Seems the config flag is being dropped.

This looks to have broken optimized tablegen builds with VS2015 even when the new switch is enabled. I'm guessing that option isn't passed into the cmake run for generating the optimized tablegen?

r353463 should fix that.