HomePhabricator

[WebAssembly] Make disassembler always emit most canonical name.

Description

[WebAssembly] Make disassembler always emit most canonical name.

Summary:
There are a few instructions that all map to the same opcode, so
when disassembling, we have to pick one. That was just the first one
before (the except_ref variant in the case of "call"), now it is the
one marked as IsCanonical in tablegen, or failing that, the shortest
name (which is typically the "canonical" one).

Also introduced a canonical "end" instruction for this purpose.

Reviewers: dschuff, tlively

Subscribers: sbc100, jgravelle-google, aheejin, llvm-commits, sunfish

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D57713

Details

Committed
aardappelFeb 4 2019, 5:19 PM
Differential Revision
D57713: [WebAssembly] Make disassembler always emit most canonical name.
Parents
rL353130: [Python2 to Python 3] Fix print -> print().
Branches
Unknown
Tags
Unknown

Event Timeline

This commit cause failure on clang-ppc64be-linux-lnt

aheejin added a comment.EditedFeb 5 2019, 2:48 PM

Thanks for the report. Disabled the failing line temporarily in rL353234 until it is fixed. I also filed PR40620 for this.