HomePhabricator

[CMake] Get back some variables used in AddLLVM.cmake
AuditedrL352058

Description

[CMake] Get back some variables used in AddLLVM.cmake

This fixes 'gtest/gtest.h' file not found when building unit tests after r351863.

Details

Auditors
stella.stamenova
Committed
stefan.graenitzJan 24 2019, 8:02 AM
Parents
rL352057: [scudo] Tuning changes based on feedback from current use
Branches
Unknown
Tags
Unknown

Event Timeline

All concerns with this commit have now been addressed.Jan 24 2019, 8:59 AM

@sgraenitz: Out of curiosity, is LLVM_LIBRARY_DIR needed here? From what I can tell it's only used in this file. Also, LLVM_MAIN_INCLUDE_DIR was already defined above, so I'll go ahead and remove one of them.

@sgraenitz: Out of curiosity, is LLVM_LIBRARY_DIR needed here? From what I can tell it's only used in this file. Also, LLVM_MAIN_INCLUDE_DIR was already defined above, so I'll go ahead and remove one of them.

Nevermind, I now realize these are all used in AddLLVM... just like your commit message said. :)