HomePhabricator

Resubmit rL345008 "Split MachinePipeliner code into header and cpp files"

Description

Resubmit rL345008 "Split MachinePipeliner code into header and cpp files"

The commit caused unclear failures in http://green.lab.llvm.org/green//job/lldb-cmake/
will revert if the error reappears

Differential Revision: https://reviews.llvm.org/D56084

Details

Event Timeline

fhahn added a subscriber: fhahn.Jan 3 2019, 11:12 AM

It looks like this commit breaks the lldb-cmake bot again, with the following error (http://green.lab.llvm.org/green/job/lldb-cmake/16085/consoleFull#-15612593049ba4694-19c4-4d7e-bec5-911270d8a58c) :

: && /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++  -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/module.cache -fcxx-modules -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -mmacosx-version-min=10.9 -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-dead_strip tools/clang/tools/clang-format/CMakeFiles/clang-format.dir/ClangFormat.cpp.o  -o bin/clang-format  -Wl,-rpath,@loader_path/../lib lib/libLLVMSupport.a lib/libclangBasic.a lib/libclangFormat.a lib/libclangRewrite.a lib/libclangToolingCore.a lib/libclangToolingInclusions.a lib/libclangToolingCore.a lib/libclangRewrite.a lib/libclangAST.a lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a lib/libLLVMMC.a lib/libLLVMBinaryFormat.a lib/libLLVMDebugInfoCodeView.a lib/libLLVMDebugInfoMSF.a lib/libLLVMSupport.a -lz -lcurses -lm lib/libLLVMDemangle.a && :
Undefined symbols for architecture x86_64:
  "llvm::MachineInstr::print(llvm::raw_ostream&, bool, bool, bool, bool, llvm::TargetInstrInfo const*) const", referenced from:
      llvm::NodeSet::print(llvm::raw_ostream&) const in ClangFormat.cpp.o
ld: symbol(s) not found for architecture x86_64

I managed to reproduce the failure locally. I get the failure if I do a second stage build using a recent build of llvm with

cmake '-G' 'Ninja' ../../llvm '-DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE' '-DCMAKE_BUILD_TYPE=Release' '-DCMAKE_MAKE_PROGRAM=/usr/local/bin/ninja' '-DLLVM_VERSION_PATCH=99' '-DLLVM_ENABLE_MODULES=On' -DCMAKE_C_COMPILER=/Foo/builds/release-with-assertions/bin/clang -DCMAKE_CXX_COMPILER=/Foo/release-with-assertions/bin/clang++

fhahn added a comment.Jan 3 2019, 11:17 AM

Looks like the patch has just been reverted in rL350345. Please let me know if you have problems reproducing the failure.

lsaba added a comment.Jan 3 2019, 11:53 AM

Looks like the patch has just been reverted in rL350345. Please let me know if you have problems reproducing the failure.

Hi,
Thanks, I will try to reproduce locally now