HomePhabricator

[InstCombine] [NFC] testcases for canonicalize MUL with NEG operand

Description

[InstCombine] [NFC] testcases for canonicalize MUL with NEG operand

Details

Committed
shchenzDec 20 2018, 2:37 PM
Parents
rL349846: Fix Windows build failures caused by r349839
Branches
Unknown
Tags
Unknown

Event Timeline

jsji added a subscriber: jsji.Dec 20 2018, 3:02 PM

Minor comment.

/llvm/trunk/test/Transforms/InstCombine/mul.ll
457

The operands will be reordered according to complexity first,
so this test will actually be the same as above, just with different symbol names.

And we have more complex version with similar pattern in llvm/test/Transforms/InstCombine/operand-complexity.ll,
so I think this test can be removed.

shchenz marked an inline comment as done.Dec 20 2018, 3:16 PM
shchenz added inline comments.
/llvm/trunk/test/Transforms/InstCombine/mul.ll
457

Thanks for your comment. Already update in patch https://reviews.llvm.org/D55961