HomePhabricator

[CMake] Unconditionally add .h and .td files to target sources
Concern RaisedrL344218

Description

[CMake] Unconditionally add .h and .td files to target sources

Previously adding header and table gen files was conditional on using an IDE. Since these files have the HEADER_FILE_ONLY attribute applied they are ignored as sources by all non-IDE generators, so there is really no reason not to include them.

Additionally having the CMake always include these files allows the CMake-server to include them in the sources list for targets, which is valuable to anyone using CMake-server integrated tools.

Details

Auditors
mgorny
Committed
cbienemanOct 10 2018, 9:02 PM
Parents
rL344217: [Coverage] Apply filtered paths to summary
Branches
Unknown
Tags
Unknown

Event Timeline

mgorny added a subscriber: mgorny.Mar 10 2019, 12:29 AM

This is causing build failures to some of our users: https://bugs.gentoo.org/674662

Apparently ADDITIONAL_HEADER_DIRS in lib/Support includes ${Backtrace_INCLUDE_DIRS} which evaluates to /usr/include. Now, if there's at least a single broken symlink in there, CMake goes crazy. Is it really intentional to take the whole system include directory there?

mgorny raised a concern with this commit.Mar 10 2019, 12:29 AM
mgorny added a subscriber: beanz.
This commit now has outstanding concerns.Mar 10 2019, 12:29 AM