HomePhabricator

lld-link: print demangled symbol names for "undefined symbol" diagnostics

Description

lld-link: print demangled symbol names for "undefined symbol" diagnostics

For this, add a few toString() calls when printing the "undefined symbol"
diagnostics; toString() already does demangling on Windows hosts.

Also make lld::demangleMSVC() (called by toString(Symbol*)) call LLVM's
microsoftDemangle() instead of UnDecorateSymbolName() so that it works on
non-Windows hosts – this makes both updating tests easier and provides a better
user experience for people doing cross-links.

This doesn't yet do the right thing for symbols starting with __imp_, but that
can be improved in a follow-up.

Differential Revision: https://reviews.llvm.org/D52104

Details

Committed
nicoSep 15 2018, 11:27 AM
Differential Revision
D52104: lld-link: print demangled symbol names for "undefined symbol" diagnostics
Parents
rL342331: Merge Demangle change in r342330 to libcxxabi.
Branches
Unknown
Tags
Unknown