HomePhabricator

Commit Detail

Description

[CodeGenPrepare] Add BothExtension type to PromotedInsts

This patch fixes PR38125.

Instruction extension types are recorded in PromotedInsts, it can be used later in function canGetThrough. If an instruction has two users with different extension types, it will be inserted into PromotedInsts two times in function promoteOperandForOther. The second one overwrites the first one, and the final extension type is wrong, later causes problem in canGetThrough.

This patch changes the simple bool extension type to 2-bit enum type, add a BothExtension type in addition to zero/sign extension. When an user sees BothExtension for an instruction, it actually knows nothing about how that instruction is extended.

Differential Revision: https://reviews.llvm.org/D49512

Details

Committed
CarrotAug 15 2018, 3:08 PM
Differential Revision
D49512: [CodeGenPrepare] Add BothExtension type to PromotedInsts
Parents
rL339821: AMDGPU: Fold fneg into fmed3
Branches
Unknown
Tags
Unknown

Event Timeline