HomePhabricator

Fix crash in bounds checking.

Description

Fix crash in bounds checking.

In r337830 I added SCEV checks to enable us to insert fewer bounds checks. Unfortunately, this sometimes crashes when multiple bounds checks are added due to SCEV caching issues. This patch splits the bounds checking pass into two phases, one that computes all the conditions (using SCEV checks) and the other that adds the new instructions.

Differential Revision: https://reviews.llvm.org/D49946

Details

Committed
jgalensonAug 3 2018, 10:12 AM
Differential Revision
D49946: Fix crash in bounds checking
Parents
rL338901: Add raw_ostream wrapper to the Stream class
Branches
Unknown
Tags
Unknown

Event Timeline

Could you commit this to the 7.0.0 branch as well, if you haven't done that yet?

Could you commit this to the 7.0.0 branch as well, if you haven't done that yet?

@hans

hans added a comment.Aug 8 2018, 6:15 AM

Could you commit this to the 7.0.0 branch as well, if you haven't done that yet?

@hans

Merged in r339239. Thanks for catching it!