HomePhabricator

[MemorySSAUpdater] Remove deleted trivial Phis from active workset

Description

[MemorySSAUpdater] Remove deleted trivial Phis from active workset

Bug fix for PR37808. The regression test is a reduced version of the
original reproducer attached to the bug report. As stated in the report,
the problem was that InsertedPHIs was keeping dangling pointers to
deleted Memory-Phis. MemoryPhis are created eagerly and sometimes get
zapped shortly afterwards. I've used WeakVH instead of an expensive
removal operation from the active workset.

Differential Revision: https://reviews.llvm.org/D48372

Details

Committed
alelab01Jul 16 2018, 12:51 AM
Differential Revision
D48372: [MemorySSAUpdater] Remove deleted trivial Phis from active workset
Parents
rL337148: [Sema] Add fixit for unused lambda captures
Branches
Unknown
Tags
Unknown