HomePhabricator

IR: Skip -print-*-all after -print-*

Description

IR: Skip -print-*-all after -print-*

This changes -print-* from transformation passes to analysis passes so
that -print-after-all and -print-before-all don't trigger. This
avoids some redundant output.

Patch by Son Tuan Vu!

Details

Committed
dexonsmithJul 11 2018, 4:30 PM
Parents
rL336868: [CodeGen] Emit more precise AssertZext/AssertSext nodes.
Branches
Unknown
Tags
Unknown

Event Timeline

twoh added a subscriber: twoh.Jun 18 2019, 11:23 PM

Hello, can you please explain a bit more about this change? What kind of redundant outputs avoided by this? Thanks!

Hello, can you please explain a bit more about this change? What kind of redundant outputs avoided by this? Thanks!

-print-after-all dumps IR after every pass. The other -print-* passes dump IR. There's no reason to dump IR again right after dumping IR.

twoh added a comment.Jun 19 2019, 10:37 AM

@dexonsmith Thank you for your reply. Are you considering the case where -print-after-all is used along with -print-* pass? If so, shouldn't we have -print-module explicitly in the test case?