HomePhabricator

[X86] Add builtins for vector element insert and extract for different 128 and…

Description

[X86] Add builtins for vector element insert and extract for different 128 and 256 bit vector types. Use them to implement the extract and insert intrinsics.

Previously we were just using extended vector operations in the header file.

This unfortunately allowed non-constant indices to be used with the intrinsics. This is incompatible with gcc, icc, and MSVC. It also introduces a different performance characteristic because non-constant index gets lowered to a vector store and an element sized load.

By adding the builtins we can check for the index to be a constant and ensure its in range of the vector element count.

User code still has the option to use extended vector operations themselves if they need non-constant indexing.

Details

Committed
ctopperJun 5 2018, 5:24 PM
Parents
rL334056: Fix test failures after r334053.
Branches
Unknown
Tags
Unknown