HomePhabricator

[InstCombine] call simplify before trying vector folds

Description

[InstCombine] call simplify before trying vector folds

As noted in the review thread for rL333782, we could have
made a bug harder to hit if we were simplifying instructions
before trying other folds.

The shuffle transform in question isn't ever a simplification;
it's just a canonicalization. So I've renamed that to make that
clearer.

This is NFCI at this point, but I've regenerated the test file
to show the cosmetic value naming difference of using
instcombine's RAUW vs. the builder.

Possible follow-ups:

  1. Move reassociation folds after simplifies too.
  2. Refactor common code; we shouldn't have so much repetition.

Details

Committed
spatelJun 2 2018, 9:27 AM
Parents
rL333819: [NEON] Support VLD1xN intrinsics in AArch32 mode (Clang part)
Branches
Unknown
Tags
Unknown