HomePhabricator

[ORC] Plumb error notifications through the VSO interface.

Description

[ORC] Plumb error notifications through the VSO interface.

This allows materializers to notify the VSO that they were unable to
resolve or finalize symbols.

Details

Committed
lhamesApr 12 2018, 11:35 AM
Parents
rL329933: [X86] Remove gpr shift/extension schedule itineraries (PR37093)
Branches
Unknown
Tags
Unknown

Event Timeline

aivchenk added inline comments.
/llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp
338–340

Should it be

assert((I == Symbols.end() || !I->second.Flags.isMaterializing()) &&
           "Attempt to replace materializing symbol definition");

?

lhames added inline comments.Apr 19 2018, 12:35 PM
/llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp
338–340

It should! Thanks for catching this. I've fixed it in r329934.

glad to help :)