HomePhabricator

[CGBlocks] Improve line info in backtraces containing *_helper_block

Description

[CGBlocks] Improve line info in backtraces containing *_helper_block

Instead of only setting a non-zero debug location on the return
instruction in *_helper_block functions, set a proper location on all
instructions within these functions. Pick the start location of the
block literal expr for maximum clarity.

The debugger does not step into *_helper_block functions during normal
single-stepping because we mark their parameters as artificial. This is
what we want (the functions are implicitly generated and uninteresting
to most users). The stepping behavior is unchanged by this patch.

rdar://32907581

Differential Revision: https://reviews.llvm.org/D39310

Details

Committed
vedantkOct 26 2017, 2:27 PM
Differential Revision
D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block
Parents
rL316703: Do not add discriminator encoding for debug intrinsics.
Branches
Unknown
Tags
Unknown