HomePhabricator

Avoid PointerIntPair of constexpr EvalInfo structs

Description

Avoid PointerIntPair of constexpr EvalInfo structs

They are stack allocated, so their alignment is not to be trusted.
32-bit MSVC only guarantees 4 byte stack alignment, even though alignof
would tell you otherwise. I tried fixing this with __declspec align, but
that apparently upsets GCC. Hopefully this version will satisfy all
compilers.

See PR32018 for some info about the mingw issues.

Should supercede https://reviews.llvm.org/D34873

Details

Committed
rnkAug 14 2017, 6:17 PM
Parents
rL310904: [SLPVectorizer] Replace VL[0] to VL0 with assert, add propagateIRFlags extra…
Branches
Unknown
Tags
Unknown

Event Timeline

yvvan added a subscriber: yvvan.Aug 15 2017, 1:38 AM

Fixes the crash for me. I will close my review when this one is accepted.

rnk added a subscriber: hans.Aug 15 2017, 9:13 AM

Fixes the crash for me. I will close my review when this one is accepted.

It's already committed. Do you mean we should merge it to 5.0?

Oh sorry, I didn't realize it's a commit :)

But if it's not in 5.0 it would be really good to have it there!

nik added a subscriber: nik.Oct 20 2017, 7:32 AM

hans: +1 for having this cherry-picked to 5.0. Applies cleanly here.

hans added a subscriber: tstellar.Oct 22 2017, 11:58 PM

+Tom who manages the 5.0.1 release.

nik added a comment.Nov 1 2017, 4:23 AM

+Tom who manages the 5.0.1 release.

Tom?