HomePhabricator

[XRay] Fix computation of function size subject to XRay threshold

Description

[XRay] Fix computation of function size subject to XRay threshold

Summary:
Currently XRay compares its threshold against Function::size() . However, Function::size() returns the number of basic blocks (as I understand, such as cycle bodies, if/else bodies, switch-case bodies, etc.), rather than the number of instructions.

The name of the parameter -fxray-instruction-threshold=N, as well as XRay documentation at http://llvm.org/docs/XRay.html , suggests that instructions should be counted, rather than the number of basic blocks.

I see two options:

  1. Count the number of MachineInstr`s in MachineFunction : this gives better estimate for the number of assembly instructions on the target. So a user can check in disassembly that the threshold works more or less correctly.
  2. Count the number of Instruction`s in a Function : AFAIK, this gives correct number of IR instructions, which the user can check in IR listing. However, this number may be far (several times for small functions) from the number of assembly instructions finally emitted.

Option 1 is implemented in this patch because I think that having the closer estimate for the number of assembly instructions emitted is more important than to have a clear definition of the metric.

Reviewers: dberris, rengolin

Reviewed By: dberris

Subscribers: llvm-commits, iid_iunknown

Differential Revision: https://reviews.llvm.org/D34027

Details

Committed
rSergeJun 9 2017, 6:23 AM
Reviewer
dberris
Differential Revision
D34027: [XRay] Fix computation of function size subject to XRay threshold
Parents
rL305071: [ELF] - Fix build bot.
Branches
Unknown
Tags
Unknown