Optimize orphan placement in a general way.
Audit RequiredrL302903

Description

Optimize orphan placement in a general way.

We used to place orphans by just using compareSectionsNonScript.

Then we noticed that since linker scripts can use another order, we
should first try match the section to a given PT_LOAD. But there is
nothing special about PT_LOAD. The same issue can show up for
PT_GNU_RELRO for example.

In general, we have to search for the most similar section and put the
orphan next to it. Most similar being defined as how long they follow
the same code path in compareSecitonsNonScript.

That is what this patch does. We now compute a rank for each output
section, with a bit for each branch in what was
compareSectionsNonScript.

With this findOrphanPos is now fully general and orphan placement can
be optimized by placing every section with the same rank at once.

The included testcase is a variation of many-sections.s that uses
allocatable sections to avoid the fast path in the existing
code. Without threads it goes form 46 seconds to 0.9 seconds.

Details

Auditors
Bigcheese
Committed
rafaelMay 12 2017, 7:52 AM
Parents
rL302902: [Polly][NewPM] Port ScopDetection to the new PassManager
Branches
Unknown
Tags
Unknown