HomePhabricator

Add an index for Module Metadata record in the bitcode

Description

Add an index for Module Metadata record in the bitcode

This index record the position for each metadata record in
the bitcode, so that the reader will be able to lazy-load
on demand each individual record.

We also make sure that every abbrev is emitted upfront so
that the block can be skipped while reading.

I don't plan to commit this before having the reader
counterpart, but I figured this can be reviewed mostly
independently.

Recommit r290684 (was reverted in r290686 because a test
was broken) after adding a threshold to avoid emitting
the index when unnecessary (little amount of metadata).
This optimization "hides" a limitation of the ability
to backpatch in the bitstream: we can only backpatch
safely when the position has been flushed. So if we emit
an index for one metadata, it is possible that (part of)
the offset placeholder hasn't been flushed and the backpatch
will fail.

Differential Revision: https://reviews.llvm.org/D28083

Details

Committed
mehdi_aminiDec 28 2016, 2:30 PM
Differential Revision
D28083: Add an index for Module Metadata record in the bitcode
Parents
rL290689: Decrease kLargeMalloc block size in ASAN unit tests.
Branches
Unknown
Tags
Unknown