HomePhabricator

Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits"

Description

Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits"

This seems to have increased LTO compile time bejond 2x of previous builds.
See http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto/10676/

Details

Committed
ributzkaOct 27 2016, 9:01 PM
Parents
rL285380: [Reassociate] Removing instructions mutates the IR.
Branches
Unknown
Tags
Unknown

Event Timeline

Hi Juergen,

Do you have any more details you can give me on the regressions? A repro would be best, otherwise I'm just going to be poking in the dark on this one..... Looking through the build server logs there seems to be plenty of other times where this buildbot takes a lot longer to build, sometimes for a single build other times for many.

Simon.

Hi Simon,

I don't have more details either, but I will instrument a build and see what I can find.

Hi Simon,

This might have been really unfortunate timing. We added a few faster machines, which screwed with the timeout calculation (which is based on the previous builds). We changed the job to only build on the faster machines now.

Sorry about that. Please land your change again.

Cheers,
Juergen

Thanks for the update. I've reapplied the patch at rL285494