HomePhabricator

Added support to the ASTImporter for C++ constructor initializers.

Description

Added support to the ASTImporter for C++ constructor initializers.

Thanks to Aleksei Sidorin for review and advice.

Details

Committed
spyffeMay 13 2016, 10:20 PM
Parents
rL269545: Add testing in llvm-lto for ThinLTO caching.
Branches
Unknown
Tags
Unknown

Event Timeline

I reverted this CL with r269575 because of test failures on CMake and Android buildbots - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14699. Feel free to re-submit it once the test issue is resolved.

spyffe added a subscriber: spyffe.May 16 2016, 9:44 AM

Thanks Oleksiy. I’ll look into that this morning.

Sean

I see the problem. The patch is fine, but default constructors aren’t handled yet.
There are two parts to fixing this.

First, CXXDefaultInitExpr needs to be imported correctly.
Second, someone’s trying to import a CXXConstructorDecl *without checking it.

I’ll fix both of those and re-commit.

Sean

I also needed to implement CXXNamedCastExpr for that one, sigh. I just need to add a Clang-side test case for the default init.

Sean

I’ve committed 269693, which should fix our bots.

Sean

Thank you, Sean.