HomePhabricator

ValueMapper: Stop memoizing ConstantAsMetadata

Description

ValueMapper: Stop memoizing ConstantAsMetadata

Stop memoizing ConstantAsMetadata in ValueMapper::mapMetadata. Now we
have to recompute it, but these metadata aren't particularly common, and
it restricts the lifetime of the Metadata map unnecessarily.

(The motivation is that I have a patch which uses a single Metadata map
for the lifetime of IRMover. Mehdi profiled r266446 with the patch
applied and we saw a pretty big speedup in lib/Linker.)

Details

Committed
dexonsmithApr 15 2016, 8:39 PM
Parents
rL266512: [DebugInfo] Correct the assertion introduced in r266509 + update test.
Branches
Unknown
Tags
Unknown