HomePhabricator

Sink DI metadata usage out of MachineInstr.h and MachineInstrBuilder.h

Description

Sink DI metadata usage out of MachineInstr.h and MachineInstrBuilder.h

MachineInstr.h and MachineInstrBuilder.h are very popular headers,
widely included across all LLVM backends. It turns out that there only a
handful of TUs that actually care about DI operands on MachineInstrs.

After this change, touching DebugInfoMetadata.h and rebuilding llc only
needs 112 actions instead of 542.

Details

Committed
rnkApr 14 2016, 11:29 AM
Parents
rL266350: [ValueMapper] Range-loopify to improve readability. NFC.
Branches
Unknown
Tags
Unknown

Event Timeline

Hi,

we have bunch of new failures on LLDB cmake build bot with ToT - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13420
It's failing due clang issue - CalledProcessError: Command 'make ARCH=x86_64 CC="/lldb-buildbot/lldbSlave/buildWorkingDir/scripts/../build/bin/clang" ' returned non-zero exit status 2
Is it possible that it's caused by this your CL?

rnk added a comment.Apr 14 2016, 12:59 PM

It's possible, but I have LLDB in my checkout and I ran 'check-all' on Linux and it came back green.