HomePhabricator

[Statepoints] Initial support for relocating vectors of pointers

Description

[Statepoints] Initial support for relocating vectors of pointers

Currently, we try to split vectors of pointers back into their component pointer elements during rewrite-statepoints-for-gc. This is less than ideal since presumably the vectorizer chose to vectorize for a reason. :) It's also been a source of bugs - in particular, the relocation logic as currently implemented was recently discovered to be wrong.

The alternate approach is to allow gc.relocates of vector-of-pointer type and update the backend to handle them. That's what this patch tries to do. This won't actually enable vector-of-pointers in practice - there are some RS4GC changes needed - but the lowering is standalone and testable so it makes sense to separate.

Note that there are some known cases around vector constants which this patch does not handle. Once this is in, I'll send another patch with individual fixes and test cases.

Differential Revision: http://reviews.llvm.org/D15632

Details

Committed
reamesJan 6 2016, 7:32 PM
Differential Revision
D15632: [Statepoints] Relocating vectors of pointers
Parents
rL257021: [WebAssembly] Add -m:e to the target triple.
Branches
Unknown
Tags
Unknown