HomePhabricator

[MemoryBuiltins] Delete dead code [NFC]

Description

[MemoryBuiltins] Delete dead code [NFC]

Details

Committed
reamesDec 29 2015, 9:04 AM
Parents
rL256564: [TrailingObjects] Use a different technique to determine if a getDecl
Branches
Unknown
Tags
Unknown

Event Timeline

Can this be reverted? We are using it internally. It is a basic utility anyway.

reames added a comment.Jan 4 2016, 3:20 PM

I do not plan to revert this change. My reasoning is as follows:

  1. The code is unused and untested in tree. We have a general policy of

not supporting usage of internal interfaces by external consumers.

  1. What exactly "realloc like" means is unclear at best. See my

response to the current llvm-dev thread "Optimizing memory allocation
for custom allocators and non C code" on what all is confused by these
predicates.

  1. Given the only two functions that are "realloc like" are "realloc"

and "reallocf", it's not clear what you gain over simply using the TLI
analysis directly.

If you want to reintroduce this API, I'm happy to review a patch, but
I'm going to require that it addresses the issues above.

Philip