HomePhabricator

[x86] Exclusion of incorrect include headers paths for MCU target

Description

[x86] Exclusion of incorrect include headers paths for MCU target

Exclusion of /usr/include and /usr/local/include headers paths for MCU target.

Differential Revision: http://reviews.llvm.org/D14954

Details

Committed
asbokhanNov 27 2015, 4:18 AM
Differential Revision
D14954: [x86] Exclusion of incorrect include headers paths for MCU target
Parents
rL254194: Re-add an xfail removed by r254163
Branches
Unknown
Tags
Unknown

Event Timeline

tra added a subscriber: tra.Dec 4 2015, 5:05 PM

Could you elaborate a bit on what this change actually does? The log says that it's supposed to exclude include paths, but the changes don't seem to be doing anything related to include path manipulation at all. Nor do they seem to have anything to do with x86.

/cfe/trunk/lib/CodeGen/CodeGenModule.cpp
1174–1189

This does not look right.

First we get GV from G.GV. I assume it contains some useful info.
However, we immediately replace it with a cast<>, assuming the cast will always succeed, which is not necessarily the case (e.g we may get llvm::Constant which can't be cast to GlobalValue).
Then we still check GV for non-null value, even though we assume that the cast above succeeded.

andreybokhanko added inline comments.
/cfe/trunk/lib/CodeGen/CodeGenModule.cpp
1174–1189

Artem, I committed an incorrect patch by a mistake. Reid reverted it in r254823 (thanks Reid!)

It is really still WIP. I will address your comments in the final version.

Andrey