HomePhabricator

Testcase and fix for bug 24074

Description

Testcase and fix for bug 24074

Summary:
In bug 24074, the type information is not shown
correctly. This commit includes the following -
-> Changes for displaying correct type based on
current lexical scope for the command "image
lookup -t"

-> The corresponding testcase.

-> This patch was reverted due to segfaults in
FreeBSD and Mac, I fixed the problems for both now.

Reviewers: emaste, granata.enrico, jingham, clayborg

Differential Revision: http://reviews.llvm.org/D13290

Details

Committed
ravithejaOct 8 2015, 2:45 AM
Differential Revision
D13290: Testcase and fix for bug 24074
Parents
rL249672: [OPENMP 4.1] Codegen for array sections/subscripts in 'reduction' clause.
Branches
Unknown
Tags
Unknown

Event Timeline

tberghammer added inline comments.
/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
3058–3068

Hi Ravi,

Can you explain me what is the purpose of this specific part of your change especially why you have to call GetFunction?

In the current version of the code I see an infinite recursion in stack unwinding for a specific application (can send it to you if needed, but it isn't a simple one). If I remove the GetFunction call then my problem go away and the test you added still passes on x86_64, but I don't want to do it without understanding why the GetFunction call was added in at the first place to a function what should search for a Type.

Thanks,
Tamas

ravitheja added inline comments.Oct 14 2015, 1:51 AM
/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
3058–3068

Hi,

I added the call to GetFunction because, it finds and fills the symbolcontext with the info of the function corresponding to the DwarfDIE. The testcase probably passes even if u remove the call because it contains only one function, had there been 2 functions in the test file, then it would start to fail because the symbol context would lack the function information.