HomePhabricator

[X86] Make sure startproc/endproc are paired
AuditedrL247435

Description

[X86] Make sure startproc/endproc are paired

We used different conditions to determine if we should emit startproc vs
endproc. Use the same condition to ensure that they will always be
paired.

This fixes PR24374.

Details

Auditors
nadav
tstellarAMD
Group Auditors
Restricted Project
Committed
majnemerSep 11 2015, 10:34 AM
Parents
rL247434: Update test expectations for LLVM asm printing change
Branches
Unknown
Tags
Unknown

Event Timeline

rnk added a subscriber: rnk.

We should merge this to 3.7.1 if there's still time. It's been reported multiple times:
https://llvm.org/bugs/show_bug.cgi?id=24374

tstellarAMD added auditors: Restricted Project, nadav.Nov 19 2015, 9:47 AM
tstellarAMD added a subscriber: tstellarAMD.

Hi Nadav,

Is this OK to merge to the 3.7 branch?

nadav added a subscriber: nadav.Nov 19 2015, 9:51 AM

Yes, we should merge this. LGTM!

tstellarAMD added a project: Restricted Project.Nov 20 2015, 5:11 PM