HomePhabricator

[PowerPC] Don't always consider P8Altivec-only masks in LowerVECTOR_SHUFFLE
AuditedrL246675

Description

[PowerPC] Don't always consider P8Altivec-only masks in LowerVECTOR_SHUFFLE

LowerVECTOR_SHUFFLE needs to decide whether to pass a vector shuffle off to the
TableGen-generated matching code, and it does this by testing the same
predicates used by the TableGen files. Unfortunately, when we added new
P8Altivec-only predicates, we started universally testing them in
LowerVECTOR_SHUFFLE, and if then matched when targeting a system prior to a P8,
we'd end up with a selection failure.

Details

Auditors
tstellarAMD
llvm-commits
hfinkel
Group Auditors
Restricted Project
Committed
hfinkelSep 2 2015, 9:52 AM
Parents
rL246674: Added an ExpressionParser plugin skeleton with nothing in it (yet).
Branches
Unknown
Tags
Unknown

Event Timeline

wschmidt added auditors: Restricted Project, llvm-commits, tstellarAMD, hfinkel.Oct 30 2015, 9:50 AM
wschmidt added a subscriber: wschmidt.

Addresses a serious problem on pre-P8 hardware.

hfinkel accepted this commit.Nov 9 2015, 6:52 AM
tstellarAMD added a project: Restricted Project.Nov 9 2015, 11:49 AM