HomePhabricator

[LLDB][MIPS] Create Unix Signals based on target architecture
AuditedrL243618

Description

[LLDB][MIPS] Create Unix Signals based on target architecture

SUMMARY:
The patch creates Unix Signals based on target architecture. For MIPS it creates MipsLinuxSignals.

Reviewers: clayborg
Subscribers: mohit.bhakkad, sagar, lldb-commits
Differential Revision: http://reviews.llvm.org/D11455

Details

Auditors
chaoren
Committed
jaydeepJul 29 2015, 10:06 PM
Parents
rL243617: Merging r243615:
Branches
Unknown
Tags
Unknown

Event Timeline

Hi Hans,

Could you please merge it to release branch?

Thanks,
Jaydeep

chaoren raised a concern with this commit.Aug 14 2015, 12:50 PM
chaoren added a subscriber: chaoren.
chaoren added inline comments.
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
829

This needs to be

SetUnixSignals(std::make_shared<GDBRemoteSignals>(platform_sp->GetUnixSignals()))

so the process gets its own copy.