HomePhabricator

Move ADB communications to AdbClient class - to make it accessible by other…

Description

Move ADB communications to AdbClient class - to make it accessible by other components.

http://reviews.llvm.org/D8535

Details

Auditors
ki.stfu
Committed
ovyalovMar 23 2015, 2:03 PM
Parents
rL233020: Refactor: Simplify boolean expressions in R600 target
Branches
Unknown
Tags
Unknown

Event Timeline

ki.stfu added subscribers: ovyalov, Unknown Object (MLST), ki.stfu.Mar 23 2015, 3:17 PM

It added a new warning.

/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
41
[4/13] Building CXX object tools/lldb/source/Plugins/Platform/Android/C...iles/lldbPluginPlatformAndroid.dir/PlatformAndroidRemoteGDBServer.cpp.o
../tools/lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:41:83: warning: format specifies type 'unsigned long long' but the argument has type 'size_type' (aka 'unsigned long') [-Wformat]
        return Error ("Expected a single connected device, got instead %" PRIu64, connect_devices.size ());
                                                                       ~~~        ^~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
ki.stfu raised a concern with this commit.Mar 23 2015, 3:18 PM
ki.stfu resigned from this audit.Mar 23 2015, 11:08 PM

Thx