HomePhabricator

Fixed a bug in memory dependence checking module of loop vectorization. The…

Description

Fixed a bug in memory dependence checking module of loop vectorization. The following loop should not be vectorized with current algorithm.

{code}
// loop body

... = a[i]          (1)
 ... = a[i+1]       (2)

.......
a[i+1] = .... (3)

a[i] = ...          (4)

{code}

The algorithm tries to collect memory access candidates from AliasSetTracker, and then check memory dependences one another. The memory accesses are unique in AliasSetTracker, and a single memory access in AliasSetTracker may map to multiple entries in AccessAnalysis, which could cover both 'read' and 'write'. Originally the algorithm only checked 'write' entry in Accesses if only 'write' exists. This is incorrect and the consequence is it ignored all read access, and finally some RAW and WAR dependence are missed.

For the case given above, if we ignore two reads, the dependence between (1) and (3) would not be able to be captured, and finally this loop will be incorrectly vectorized.

The fix simply inserts a new loop to find all entries in Accesses. Since it will skip most of all other memory accesses by checking the Value pointer at the very beginning of the loop, it should not increase compile-time visibly.

Details

Committed
JiangningJan 5 2015, 2:08 AM
Parents
rL225158: Convert SmallMapVector from a class to a struct.
Branches
Unknown
Tags
Unknown