HomePhabricator

Fix tests broken by the OptionValidator changes.

Description

Fix tests broken by the OptionValidator changes.

The getopt library has a structure called option (lowercase). We
have a structure called Option (uppercase). previously the two
structures had exactly the same definitions, and we were doing a
C-style cast of an Option* to an option*. C-style casts don't
bother to warn you when you cast to unrelated types, but in the
original OptionValidator patch I modified the definition of Option.

This patch fixes the errors by building an array of option
structures and filling it out the correct way before passing it to
the getopt library.

This also fixes one other source of test failures: an uninitialized
read that occurs due to not initializing a field of the
OptionDefinition.

Reviewed By: Todd Fiala

Differential Revision: http://reviews.llvm.org/D4425

Details

Committed
zturnerJul 9 2014, 9:32 AM
Differential Revision
D4425: Fix tests broken by OptionValidator changes.
Parents
rL212627: Revert "Fix broken tests due to new error output."
Branches
Unknown
Tags
Unknown

Event Timeline