HomePhabricator

Don't forget about a builtin if we're about to redeclare it and we couldn't
rL199850Unpublished

Unpublished Commit ยท Learn More

No further details are available.

Description

Don't forget about a builtin if we're about to redeclare it and we couldn't
create an implicit declaration of it (because some type it depends on is
unavailable). This had the effect of causing us to not implicitly give it the
right attributes. It turns out that glibc's sigsetjmp is declared before
sigjmp_buf is declared, and this resulted in us not implicitly giving it
attribute__((returns_twice)), which in turn resulted in miscompiles in any C
code calling glibc's sigsetjmp.

(See also the vaguely-related sourceware.org/PR4662.)

Details

Committed
rsmithJan 22 2014, 3:07 PM
Parents
rL199849: Better inlining. However, I have two problems with this inliner:
Branches
Unknown
Tags
Unknown

Event Timeline