Diffusion LLVM Github Monorepo fe7fdcac87be

[MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions
fe7fdcac87be
Actions

Authored by jurahul on Dec 2 2020, 4:49 PM.

Tags

None

Subscribers

None

Description

[MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions

Change parseOptionalRegion to return an OptionalParseResult.
Change parseFunctionLikeOp() to fail parsing if the function body was parsed but was empty.
See https://llvm.discourse.group/t/funcop-parsing-bug/2164

Differential Revision: https://reviews.llvm.org/D91886

Details

Committed

Dec 4 2020, 9:09 AM

Differential Revision

D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions

Parents

rG245233423e46: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait.

Branches

Unknown

Tags

Unknown

Event Timeline

jurahul committed rGfe7fdcac87be: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions (authored by jurahul).Dec 4 2020, 9:09 AM

jurahul added an edge: D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

Changes (10)

Path

Size

flang/

include/

flang/

Optimizer/

Dialect/

mlir/

include/

mlir/

IR/

OpImplementation.h

lib/

Dialect/

LLVMIR/

IR/

LLVMDialect.cpp

SPIRV/

IR/

FunctionImplementation.cpp

Parser/

test/

Dialect/

SCF/

canonicalize.mlir

IR/

tools/

mlir-tblgen/

OpFormatGen.cpp

rGfe7fdcac87be

flang/include/flang/Optimizer/Dialect/FIROps.td

Loading...

mlir/include/mlir/IR/OpImplementation.h

Loading...

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Loading...

mlir/lib/Dialect/SPIRV/SPIRVOps.cpp

Loading...

mlir/lib/IR/FunctionImplementation.cpp

Loading...

mlir/lib/Parser/Parser.cpp

Loading...

mlir/test/Dialect/SCF/canonicalize.mlir

Loading...

mlir/test/IR/invalid.mlir

Loading...

mlir/test/IR/traits.mlir

Loading...

mlir/tools/mlir-tblgen/OpFormatGen.cpp

Loading...