HomePhabricator

[COFF] Implement /safeseh:no and check @feat.00 flags by default

Authored by rnk on Jul 16 2019, 11:17 AM.

Description

[COFF] Implement /safeseh:no and check @feat.00 flags by default

Summary:
Fixes PR41828. Before this, LLD always emitted SafeSEH chunks and
defined __safe_se_handler_table & size. Now, /safeseh:no leaves those
undefined.

Additionally, we were checking for the safeseh @feat.00 flag in two
places: once to emit errors, and once during safeseh table construction.
The error was set up to be off by default, but safeseh is supposed to be
on by default. I combined the two checks, so now LLD emits an error if
an input object lacks @feat.00 and safeseh is enabled. This caused the
majority of 32-bit LLD tests to fail, since many test input object files
lack @feat.00 symbols. I explicitly added -safeseh:no to those tests to
preserve behavior.

Finally, LLD no longer sets IMAGE_DLL_CHARACTERISTICS_NO_SEH if any
input file wasn't compiled for safeseh.

Reviewers: mstorsjo, ruiu, thakis

Reviewed By: ruiu, thakis

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D63570

llvm-svn: 366238

Details

Committed
rnkJul 16 2019, 11:17 AM
Reviewer
ruiu
Differential Revision
D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default
Parents
rG35c96598b124: AMDGPU/GlobalISel: Select flat loads
Branches
Unknown
Tags
Unknown