Diffusion LLVM Github Monorepo fb218170b47e

[Diagnostics] Warn if ?: with integer constants always evaluates to true
fb218170b47e
Actions

Authored by xbolva00 on Sep 22 2019, 3:00 PM.

Description

[Diagnostics] Warn if ?: with integer constants always evaluates to true

Extracted from D63082. GCC has this warning under -Wint-in-bool-context, but as noted in the D63082's review, we should put it under TautologicalConstantCompare.

llvm-svn: 372531

Details

Committed

xbolva00

Sep 22 2019, 3:00 PM

Parents

rG914c4c306d12: [clang] fixing conditional explicit for out-of-line definition PR42980

Branches

Unknown

Tags

Unknown

Event Timeline

xbolva00 committed rGfb218170b47e: [Diagnostics] Warn if ?: with integer constants always evaluates to true (authored by xbolva00).Sep 22 2019, 3:00 PM

Changes (3)

				Path	Packages
	M			clang/include/clang/Basic/DiagnosticSemaKinds.td
	M			clang/lib/Sema/SemaChecking.cpp
	A			clang/test/Sema/warn-integer-constants-in-ternary.c

rGfb218170b47e

View Options

clang/include/clang/Basic/DiagnosticSemaKinds.td

View Options

clang/lib/Sema/SemaChecking.cpp

View Options

clang/test/Sema/warn-integer-constants-in-ternary.c

[Diagnostics] Warn if ?: with integer constants always evaluates to truefb218170b47eActions

Description

Details

Event Timeline

Changes (3)

rGfb218170b47e

clang/include/clang/Basic/DiagnosticSemaKinds.td

clang/lib/Sema/SemaChecking.cpp

clang/test/Sema/warn-integer-constants-in-ternary.c

[Diagnostics] Warn if ?: with integer constants always evaluates to true
fb218170b47e
Actions