HomePhabricator

[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

Authored by erik.pilkington on Feb 7 2020, 9:37 AM.

Description

[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

These temporaries are only used in the callee, and their memory can be reused
after the call is complete.

rdar://58552124

Differential revision: https://reviews.llvm.org/D74094

Event Timeline

lei added a subscriber: lei.Feb 12 2020, 11:21 AM

This patch broke our multistage bot during stage 2 build: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546
We are investigating, please pull until we can provide a reproducer.

This patch broke our multistage bot during stage 2 build: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546
We are investigating, please pull until we can provide a reproducer.

Sure, I reverted the change here: e26c24b849211f35a988d001753e0cd15e4a9d7b

When do you think you'll have a reproducer ready? Would it be possible for me to ssh into the machine?

lei added a comment.Feb 12 2020, 12:43 PM

Thanks! Unfortunately we don't have a machine that is publically accessible. We are actively working on getting a reproducer right now, will let you know as soon as it's ready.

Thanks! Unfortunately we don't have a machine that is publically accessible. We are actively working on getting a reproducer right now, will let you know as soon as it's ready.

Month passed. Any news?

This also fixes https://bugs.llvm.org/show_bug.cgi?id=44253. Is there any update on the ppc reproducer?

This also fixes https://bugs.llvm.org/show_bug.cgi?id=44253. Is there any update on the ppc reproducer?

The IBM folks sent me some more information privately last month, but I haven't really had the time to narrow it down quite yet. I'll probably come back to this next week or so.