HomePhabricator

ValueMapper: Rename RF_MoveDistinctMDs => RF_ReuseAndMutateDistinctMDs, NFC

Authored by dexonsmith on Feb 10 2021, 3:23 PM.

Description

ValueMapper: Rename RF_MoveDistinctMDs => RF_ReuseAndMutateDistinctMDs, NFC

Rename the RF_MoveDistinctMDs flag passed into MapValue and
MapMetadata to RF_ReuseAndMutateDistinctMDs in order to more
precisely describe its effect and clarify the header documentation.

Found this while helping to investigate PR48841, which pointed out an
unsound use of the flag in CloneModule(). For now I've just added a
FIXME there, but I'm hopeful that the new (more precise) name will
prevent other similar errors.

Details

Committed
dexonsmithFeb 10 2021, 4:53 PM
Parents
rGedd365c7098d: [flang][fir][NFC] Move ShapeType to TableGen type definition
Branches
Unknown
Tags
Unknown