HomePhabricator

[lldb] Reduce some dangerous boilerplate with CompletionRequest::ShiftArguments

Authored by teemperor on Sep 23 2019, 1:16 AM.

Description

[lldb] Reduce some dangerous boilerplate with CompletionRequest::ShiftArguments

We should in general not allow external code to fiddle with the internals of
CompletionRequest, but until this is gone let's at least provide a utility
function that makes this less dangerous.

This also now correct updates the partially parsed argument list,
but it doesn't seem to be used by anything that is behind one of
the current shift/SetCursorIndex calls, so this doesn't seeem to
fix any currently used completion.

llvm-svn: 372556

Details

Committed
teemperorSep 23 2019, 1:16 AM
Parents
rGc063b0b0d334: [MIPS GlobalISel] VarArg argument lowering, select G_VASTART and vacopy
Branches
Unknown
Tags
Unknown