HomePhabricator

[libc++abi] Remove redundant link flags on Apple platforms

Authored by ldionne on Oct 7 2019, 11:12 AM.

Description

[libc++abi] Remove redundant link flags on Apple platforms

These flags are already set when we create the cxxabi_shared target
using the SOVERSION and VERSION target properties, and the install_name
was already being overriden to '@rpath/libc++abi.1.dylib' by CMake
because no 'CMAKE_INSTALL_NAME_DIR' option was specified. So this is
effectively a removal of dead code with no intended functionality change.

The only think we're losing here is that we used to link against
libSystem.B.dylib instead of libSystem.dylib when building libc++abi
for macOS 10.6 -- however, I strongly suspect nobody's building
libc++abi from source for that target anymore.

llvm-svn: 373934

Details

Committed
ldionneOct 7 2019, 11:12 AM
Parents
rG29f7e17cb8b6: Try to get clangd tests passing on Windows.
Branches
Unknown
Tags
Unknown