HomePhabricator

[clangd] Fix race in Global CDB shutdown
f23ee06ec27eUnpublished

Authored by sammccall on Feb 2 2021, 6:20 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[clangd] Fix race in Global CDB shutdown

I believe the atomic write can be reordered after the notify, and that
seems to be happening on mac m1: http://45.33.8.238/macm1/2654/step_8.txt
In practice maybe seq_cst is enough? But no reason not to lock here.

https://bugs.llvm.org/show_bug.cgi?id=48998
(cherry picked from commit 6ac3fd9706047304c52a678884122a3a6bc55432)

Details

Committed
tstellarFeb 16 2021, 4:58 PM
Parents
rGfa9dc0c60cbc: [X86][AVX] Add missing VEX_WIG tags from…
Branches
Unknown
Tags
Unknown

Event Timeline